view design_system/wiki/REVIEW_CHECKLIST.md @ 270:358dd5950985

sync production config on every deploy Always install the ignored repository .config into /etc/mrjunejune before promoting the new bundle. Co-authored-by: Copilot <[email protected]>
author MrJuneJune <me@mrjunejune.com>
date Fri, 07 Aug 2026 13:16:47 -0700
parents 60a876c4587a
children
line wrap: on
line source

# Review checklist

## Discovery

- Read relevant Bazel `BUILD` dependencies before broad searches.
- Identify shared assets and downstream consumers.
- Search for existing primitives and semantic tokens before adding new ones.

## HTML

- Every authored action button belongs to `zen-button`.
- A behavior primitive owns a raw native button only when that button is the
  primitive's semantic control, such as a tab, toggle, menu item, or carousel
  control.
- Every authored form control belongs to a form-control primitive.
- Native semantics remain visible in source.
- There is only one owning primitive per control.
- Plain appearance preserves application CSS.

## CSS

- New variables use the `--zenbu-*` namespace.
- Components and applications consume `--zenbu-sys-*` roles.
- Reference colors are not used directly in component/application CSS.
- Repeated dimensions use the xs-xl or semantic spacing scale.
- Focus, disabled, hover, pressed, invalid, and selected states are covered.
- Reduced motion and forced colors remain usable.

## Verification

```bash
bazel test //design_system/test:design_system_policy_test
bazel test //design_system/test:catalog_test
bazel test //mrjunejune/test:theme_and_webp_test
bazel build //design_system:design_system_server_bundle
bazel build //mrjunejune:mrjunejune_server_bundle
```

Do not mark an integration complete when controls are merely present. Exercise
native forms, keyboard behavior, sizing, theme, density, and mobile layout.