diff design_system/wiki/REVIEW_CHECKLIST.md @ 258:60a876c4587a

[ui] Add semantic primitive ownership Build a layered Zenbu token and sizing system, make authored controls use native-underneath primitives, migrate mrjunejune without imposing visual surfaces, and document/enforce HTML ownership in the catalog and wiki. Co-authored-by: Copilot <[email protected]>
author MrJuneJune <me@mrjunejune.com>
date Wed, 05 Aug 2026 05:25:40 -0700
parents
children
line wrap: on
line diff
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/design_system/wiki/REVIEW_CHECKLIST.md	Wed Aug 05 05:25:40 2026 -0700
@@ -0,0 +1,40 @@
+# Review checklist
+
+## Discovery
+
+- Read relevant Bazel `BUILD` dependencies before broad searches.
+- Identify shared assets and downstream consumers.
+- Search for existing primitives and semantic tokens before adding new ones.
+
+## HTML
+
+- Every authored action button belongs to `zen-button`.
+- A behavior primitive owns a raw native button only when that button is the
+  primitive's semantic control, such as a tab, toggle, menu item, or carousel
+  control.
+- Every authored form control belongs to a form-control primitive.
+- Native semantics remain visible in source.
+- There is only one owning primitive per control.
+- Plain appearance preserves application CSS.
+
+## CSS
+
+- New variables use the `--zenbu-*` namespace.
+- Components and applications consume `--zenbu-sys-*` roles.
+- Reference colors are not used directly in component/application CSS.
+- Repeated dimensions use the xs-xl or semantic spacing scale.
+- Focus, disabled, hover, pressed, invalid, and selected states are covered.
+- Reduced motion and forced colors remain usable.
+
+## Verification
+
+```bash
+bazel test //design_system/test:design_system_policy_test
+bazel test //design_system/test:catalog_test
+bazel test //mrjunejune/test:theme_and_webp_test
+bazel build //design_system:design_system_server_bundle
+bazel build //mrjunejune:mrjunejune_server_bundle
+```
+
+Do not mark an integration complete when controls are merely present. Exercise
+native forms, keyboard behavior, sizing, theme, density, and mobile layout.