Mercurial
comparison design_system/wiki/REVIEW_CHECKLIST.md @ 258:60a876c4587a
[ui] Add semantic primitive ownership
Build a layered Zenbu token and sizing system, make authored controls use native-underneath primitives, migrate mrjunejune without imposing visual surfaces, and document/enforce HTML ownership in the catalog and wiki.
Co-authored-by: Copilot <[email protected]>
| author | MrJuneJune <me@mrjunejune.com> |
|---|---|
| date | Wed, 05 Aug 2026 05:25:40 -0700 |
| parents | |
| children |
comparison
equal
deleted
inserted
replaced
| 257:609d3c6aff4e | 258:60a876c4587a |
|---|---|
| 1 # Review checklist | |
| 2 | |
| 3 ## Discovery | |
| 4 | |
| 5 - Read relevant Bazel `BUILD` dependencies before broad searches. | |
| 6 - Identify shared assets and downstream consumers. | |
| 7 - Search for existing primitives and semantic tokens before adding new ones. | |
| 8 | |
| 9 ## HTML | |
| 10 | |
| 11 - Every authored action button belongs to `zen-button`. | |
| 12 - A behavior primitive owns a raw native button only when that button is the | |
| 13 primitive's semantic control, such as a tab, toggle, menu item, or carousel | |
| 14 control. | |
| 15 - Every authored form control belongs to a form-control primitive. | |
| 16 - Native semantics remain visible in source. | |
| 17 - There is only one owning primitive per control. | |
| 18 - Plain appearance preserves application CSS. | |
| 19 | |
| 20 ## CSS | |
| 21 | |
| 22 - New variables use the `--zenbu-*` namespace. | |
| 23 - Components and applications consume `--zenbu-sys-*` roles. | |
| 24 - Reference colors are not used directly in component/application CSS. | |
| 25 - Repeated dimensions use the xs-xl or semantic spacing scale. | |
| 26 - Focus, disabled, hover, pressed, invalid, and selected states are covered. | |
| 27 - Reduced motion and forced colors remain usable. | |
| 28 | |
| 29 ## Verification | |
| 30 | |
| 31 ```bash | |
| 32 bazel test //design_system/test:design_system_policy_test | |
| 33 bazel test //design_system/test:catalog_test | |
| 34 bazel test //mrjunejune/test:theme_and_webp_test | |
| 35 bazel build //design_system:design_system_server_bundle | |
| 36 bazel build //mrjunejune:mrjunejune_server_bundle | |
| 37 ``` | |
| 38 | |
| 39 Do not mark an integration complete when controls are merely present. Exercise | |
| 40 native forms, keyboard behavior, sizing, theme, density, and mobile layout. |